fix: locales not being included when srcDir has been changed #1964
Conversation
src/layers.ts
Outdated
| @@ -149,6 +149,6 @@ export const getLayerLangPaths = (nuxt: Nuxt) => { | |||
| nuxt.options._layers | |||
| .filter(layer => layer.config.i18n?.langDir != null) | |||
| // @ts-ignore | |||
| .map(layer => pathe.resolve(layer.config.rootDir, layer.config.i18n.langDir)) as string[] | |||
| .map(layer => pathe.resolve(layer.config.rootDir, layer.config.srcDir, layer.config.i18n.langDir)) as string[] | |||
There was a problem hiding this comment.
Debugging this I found that layer.config.srcDir already has layer.config.rootDir included. So you should probably use:
pathe.resolve(layer.config.srcDir, layer.config.i18n.langDir)But I'm not sure if I'm correct with this.
There was a problem hiding this comment.
Oops. Messed up the copy&pase. I meant pathe.resolve(layer.config.srcDir, layer.config.i18n.langDir) and updated my previous comment.
There was a problem hiding this comment.
You're right, it looks like srcDir includes the absolute path, I thought it would use the configured value of srcDir. But as seen here rootDir is always part of srcDir on _layers https://github.com/nuxt/nuxt/blob/ae82d7089598bd1a4e5a8f88cd9edf7a1f12d7c7/packages/kit/src/loader/config.ts#L34
There was a problem hiding this comment.
Ah nice catch. Thank you for checking this.
|
Adding |
BobbieGoede
force-pushed
the
fix/src-dir-locale-resolve
branch
from
aeb4234
to
3db7b52
Compare
That's a good point! I will test a custom |
🔗 Linked issue
#1963
❓ Type of change
📚 Description
Resolves #1963
📝 Checklist